Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests produce OpenQASM programs which use reserved keywords as variable names #34

Closed
rmshaffer opened this issue Jun 17, 2024 · 0 comments · Fixed by #45
Closed
Assignees
Labels
bug Something isn't working

Comments

@rmshaffer
Copy link
Contributor

Describe the bug
When using amazon-braket-sdk version 1.81.1 or higher, several AutoQASM unit tests are failing because they were producing OpenQASM programs which used reserved keywords as variable names (i.e., invalid OpenQASM).

The failing tests include:

FAILED test/unit_tests/autoqasm/test_devices.py::test_aws_device_run[None-None]
FAILED test/unit_tests/autoqasm/test_devices.py::test_aws_device_run[inputs1-device_parameters1]
FAILED test/unit_tests/autoqasm/test_gate_calibrations.py::test_gate_calibrations_variable_args
FAILED test/unit_tests/autoqasm/test_gate_calibrations.py::test_gate_calibrations_bind_calibrations_not_inplace
FAILED test/unit_tests/autoqasm/test_parameters.py::test_parametric_pulse_cals
FAILED test/unit_tests/autoqasm/test_parameters.py::test_binding_pulse_parameters
FAILED test/unit_tests/autoqasm/test_pulse.py::test_pulse_freeparameter
FAILED test/unit_tests/autoqasm/test_pulse.py::test_pulse_freeparameter_bound
FAILED test/unit_tests/autoqasm/test_pulse.py::test_pulse_freeparameter_condition

To reproduce
Run AutoQASM unit tests with amazon-braket-sdk version 1.81.1 or higher installed.

Expected behavior
Unit tests should pass.

Screenshots or logs
The list of tests above fail. For example, see:
https://github.com/amazon-braket/autoqasm/actions/runs/9555470119/job/26338777025?pr=31

System information
A description of your system. Please provide:

  • AutoQASM version: 0.1.0
  • Amazon Braket Python SDK version: 1.81.1
  • Amazon Braket Python Schemas version: n/a
  • Amazon Braket Python Default Simulator version: n/a
  • Python version: n/a

Additional context
This is a direct result of Braket SDK PR: amazon-braket/amazon-braket-sdk-python#999
This is related to AutoQASM PR: #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
1 participant