Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Replace Aspen-M-3 with Ankaa-2 #103

Merged
merged 3 commits into from
Sep 26, 2024
Merged

change: Replace Aspen-M-3 with Ankaa-2 #103

merged 3 commits into from
Sep 26, 2024

Conversation

rmshaffer
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rmshaffer rmshaffer marked this pull request as ready for review September 25, 2024 21:23
@rmshaffer rmshaffer requested a review from a team as a code owner September 25, 2024 21:23
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.66%. Comparing base (f0f70f2) to head (d8b9b51).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   88.66%   88.66%           
=======================================
  Files          36       36           
  Lines        3951     3951           
=======================================
  Hits         3503     3503           
  Misses        448      448           
Flag Coverage Δ
88.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmshaffer rmshaffer merged commit 81486d8 into main Sep 26, 2024
18 of 20 checks passed
@rmshaffer rmshaffer deleted the rmshaffer/ankaa branch September 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants