-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ambassador cards shiny #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Looking great, but there are a few issues I noticed:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only remaining issue looks to be that the tooltip on conservation status is now showing in the middle of nowhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot! Let me take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @farrenr checking in if you had a chance to look at this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Apologies on taking a while with this, I've been a bit stuck on the last issue with the tooltip but I'm looking at it today
Co-authored-by: Matt Cowley <[email protected]>
I think it looks very cool, but I think it could be a bit smoother. The problem with it resetting on the edges and flickering seems to be inherent to the library: https://imgur.com/6nkHLFe I think with increasing the transition speed to like 5s or so it gets a lot smoother overall, especially when leaving the card as it does not "snap" back to quickly. I also think the glare could be less or the font contrast gets too low. Its already not the best contrast. Maybe reducing the opacity to 30% could work. Another thing i noticed, we do have a checkbox to disable the effect. Is there any way to also disable it when |
👋 Given the lack of movement on this, and the conflicts (mostly my doing, sorry), I'm going to close this for now. Please feel free to open a new PR with updates if/when you have the time. |
Resolves #67