De-duplicate species data #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes alveusgg#87 Signed-off-by: flakey5 <[email protected]>
flakey5
commented
Dec 24, 2024
Signed-off-by: flakey5 <[email protected]>
Signed-off-by: flakey5 <[email protected]>
This was referenced Dec 25, 2024
MattIPv4
reviewed
Dec 27, 2024
Signed-off-by: flakey5 <[email protected]>
Signed-off-by: flakey5 <[email protected]>
MattIPv4
reviewed
Dec 30, 2024
|
That being said, before we merge this, I'd like to have the site/extension PRs ready to go -- it looks like they need updating based on class now being within species? |
Signed-off-by: flakey5 <[email protected]>
MattIPv4
approved these changes
Dec 31, 2024
|
Tested this locally with both combinations of old/new site/extension, everything seems to be working either way 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87
Since this is breaking I'm gonna leave this as a draft until there's prs for the website & extension