Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate global lock on TopicTree #2

Open
shoenig opened this issue Feb 4, 2014 · 0 comments
Open

Eliminate global lock on TopicTree #2

shoenig opened this issue Feb 4, 2014 · 0 comments

Comments

@shoenig
Copy link
Collaborator

shoenig commented Feb 4, 2014

Right now, every AddSubscription and RemoveSubscription acquire a big nasty lock on the tree. I think this can be avoided by having locks at the node level instead. That way, you only need to W lock on the parent of the node you are removing or adding. All other operations would still be R locks.

I'm not sure if this is worth doing, and right now I just want to get something working.This issue is to remind me to take a closer look someday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant