Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header's mobile menu button briefly flashes over menu items #336

Closed
romaricpascal opened this issue Nov 17, 2023 · 1 comment
Closed

Header's mobile menu button briefly flashes over menu items #336

romaricpascal opened this issue Nov 17, 2023 · 1 comment

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Nov 17, 2023 •
edited
Loading

What should change

If you have links in the header, the mobile menu button will briefly flash on wide viewports, appearing overlaid on top of the links. It should be kept hidden on wide viewports at all time.

This can be witnessed on the Tech Docs Gem docs or GOV.UK Developer docs. The following screenshot captures the overlay, noticeable in the top right corner with the text overlap and the down arrow which shouldn't be visible. (apologies in poor quality, it's been extracted from Chrome's devtools performance recording)

menu-button-overlayed-over-menu-items
@kr8n3r
Copy link
Contributor

kr8n3r commented Oct 23, 2024

this will likely be fixed with #375

@kr8n3r kr8n3r closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Technical Documentation Template project board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romaricpascal @kr8n3r