From 820614e0baad4b203079413af40172b3ad1a0799 Mon Sep 17 00:00:00 2001
From: Sandor Arpa <sandor.arpa@digital.cabinet-office.gov.uk>
Date: Thu, 21 Sep 2023 16:53:08 +0100
Subject: [PATCH] PP-11470 show auth rejected page
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

We would expect to see an error page when payment was declined after clicking “Pay” in the Google Pay dialog, instead we see a technical problems page.

- refactor auth response controller to handle 400 return code
- add a relevant test
---
 .../handle-auth-response.controller.js        |  6 ++++++
 .../handle-auth-response.controller.test.js   | 20 ++++++++++++-------
 2 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/app/controllers/web-payments/handle-auth-response.controller.js b/app/controllers/web-payments/handle-auth-response.controller.js
index 3233a21a5..6e17575d1 100644
--- a/app/controllers/web-payments/handle-auth-response.controller.js
+++ b/app/controllers/web-payments/handle-auth-response.controller.js
@@ -64,6 +64,12 @@ const handleAuthResponse = (req, res, charge) => response => {
       }
       break
     case 400:
+      logging.failedChargePost(response.statusCode, getLoggingFields(req))
+      return responseRouter.response(req, res, 'AUTHORISATION_REJECTED', withAnalytics(
+        charge,
+        { returnUrl: routeFor('return', charge.id) },
+        webPaymentsRouteFor('handlePaymentResponse', charge.id))
+      )
     case 402:
     case 500:
       logging.failedChargePost(response.statusCode, getLoggingFields(req))
diff --git a/test/controllers/web-payments/handle-auth-response.controller.test.js b/test/controllers/web-payments/handle-auth-response.controller.test.js
index 27b458b03..d5076f7cd 100644
--- a/test/controllers/web-payments/handle-auth-response.controller.test.js
+++ b/test/controllers/web-payments/handle-auth-response.controller.test.js
@@ -128,6 +128,7 @@ describe('The web payments handle auth response controller', () => {
     expect(res.redirect.calledWith(303, '/card_details/chargeId/auth_waiting')).to.be.ok // eslint-disable-line
     done()
   })
+
   it('show capture failed page and delete connector response if connector response is in the session and and capture failed', done => {
     const mockCharge = () => {
       return {
@@ -171,6 +172,7 @@ describe('The web payments handle auth response controller', () => {
     expect(res.render.calledWith('errors/incorrect-state/capture-failure', systemErrorObj)).to.be.true // eslint-disable-line
     done()
   })
+
   it('show error page and delete connector response if connector response is in the session and error', done => {
     const mockCharge = () => {
       return {
@@ -249,13 +251,15 @@ describe('The web payments handle auth response controller', () => {
     done()
   })
 
-  it('show error page and delete connector response if connector response is in the session and status code is 400', done => {
+  it('should render the auth_failure view and delete connector response if connector response is in the session and status code is 400', done => {
     const mockCharge = () => {
       return {
         capture: () => {
           return {
-            then: function (success) {
-              return success()
+            then: function (success, fail) {
+              return fail({
+                message: 'AUTHORISATION_REJECTED'
+              })
             }
           }
         }
@@ -274,23 +278,25 @@ describe('The web payments handle auth response controller', () => {
       },
       deleteSessionVariable: sinon.spy()
     }
-    const systemErrorObj = {
-      viewName: 'SYSTEM_ERROR',
+    const authErrorObj = {
+      viewName: 'AUTHORISATION_REJECTED',
       returnUrl: '/return/3',
       analytics: {
+        path: '/handle-payment-response/3/auth_failure',
         analyticsId: 'test-1234',
         type: 'test',
         paymentProvider: 'sandbox',
-        path: '/handle-payment-response/3/error',
         amount: '4.99',
         testingVariant: 'original'
       }
     }
+
     requireHandleAuthResponseController(mockCharge, mockNormaliseCharge, mockCookies)(req, res)
     expect(mockCookies.deleteSessionVariable.calledWith(req, `ch_${chargeId}.webPaymentAuthResponse`)).to.be.ok // eslint-disable-line
-    expect(res.render.calledWith('errors/system-error', systemErrorObj)).to.be.true // eslint-disable-line
+    expect(res.render.calledWith('errors/incorrect-state/auth-failure', authErrorObj)).to.be.true // eslint-disable-line
     done()
   })
+
   it('should return error if connector response has not been saved in the session', done => {
     const res = {
       redirect: sinon.spy(),