Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probleme with the constructor of NotificationClient.cs and the http client used / configured #191

Open
eccc-fp opened this issue Oct 17, 2024 · 1 comment

Comments

@eccc-fp
Copy link

eccc-fp commented Oct 17, 2024

there is no constructor for NotificationClient.cs that accept an IHttpClient if the baseUrl is not the default one, DI cannot be properly used there

which cause another issue, the HttpClientWrapper.cs doesnt follow proper Guidelines for using HttpClient

which can cause a wide variety of issues and also it is not possible to implement a proper retry pattern

@rparke
Copy link

rparke commented Oct 18, 2024

Hi, if you're able to open a PR with an additional constructor to fix this that would be great. Otherwise it may be a few days before we are able to lend some developer time to a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants