Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancellation support for async methods #176

Open
euantorano opened this issue Sep 25, 2023 · 2 comments · May be fixed by #178
Open

Cancellation support for async methods #176

euantorano opened this issue Sep 25, 2023 · 2 comments · May be fixed by #178

Comments

@euantorano
Copy link

It would be very useful if the various *Async methods could optionally take a CancellationToken to cancel the send operation.

@samuelhwilliams
Copy link
Contributor

samuelhwilliams commented Sep 25, 2023

Hey Euan 👋

Thanks for raising an issue on this so we can track it.

We don't have any outright .NET members on our team currently, which makes prioritising this work a bit harder. We would be very keen to facilitate the Notify .NET community in working on improvements such as this independently, though. If you have the capability to put up a pull request implementing the feature we'd be very happy to help get it reviewed and released :)

@euantorano
Copy link
Author

Hi Samuel,

Thanks for the speedy response. I'll see what we can do depending on resources and time, but glad to know you're open to pull requests.

euantorano added a commit to euantorano/notifications-net-client that referenced this issue Sep 27, 2023
@euantorano euantorano linked a pull request Sep 27, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants