Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raw-editor: upgrade json editing tool #28

Open
CarlosNZ opened this issue Aug 23, 2024 · 2 comments
Open

raw-editor: upgrade json editing tool #28

CarlosNZ opened this issue Aug 23, 2024 · 2 comments

Comments

@CarlosNZ
Copy link

Heya, great project, looks very interesting!

I just stumbled upon it as you're using one of my packages for the raw editor: https://github.com/CarlosNZ/json-edit-react

I noticed the "expand" icon is getting a bit "clipped" on the left when it's in the open state:
Screenshot 2024-08-23 at 10 31 43 PM

So just wanted to let you know that this issue has been fixed so you should be able to update to the latest version (1.15.9) to make this look a little nicer :)

All the best.

@alpaylan
Copy link
Owner

Hi @CarlosNZ,

Thanks so much for pointing that out! I'll update the dependency as soon as possible. A side question, as far as I see, there is no way to remove fields entirely(I don't want them to show up on the UI). I was able to nullify the key-value, but the line was still there, albeit with no content. Is that currently possible, or would you be able to add such an option somehow?

@CarlosNZ
Copy link
Author

CarlosNZ commented Aug 25, 2024

A side question, as far as I see, there is no way to remove fields entirely(I don't want them to show up on the UI). I was able to nullify the key-value, but the line was still there, albeit with no content. Is that currently possible, or would you be able to add such an option somehow?

Yes, you should be able to do this with a Search Filter Function

// To hide all "id" fields
searchFilter={({ key }) => key !== 'id'}

I guess I'd intended the "search" to be for user input, but it doesn't have to be. (So it's perhaps not explicitly clear in the docs)

Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants