Make reservation policy owning #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillenzer
changed the title
chillenzer
force-pushed
the
topic-makeReservationPolicyOwning
branch
from
2f4a904 to
64d0aae
Compare
chillenzer
force-pushed
the
topic-makeReservationPolicyOwning
branch
from
64d0aae to
929b695
Compare
psychocoderHPC
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244.
As discussed in #244, this makes the
ReservePoolPoliciesown the pool memory. We discussed that this might go beyond the scope of a "policy" but a renaming would break backwards compatibility, so should be well thought through. Tracked in #251.