-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang-format #172
clang-format #172
Conversation
bernhardmgruber
commented
May 14, 2020
- added a .clang-format file, based on the one suggested for alpaka: Improve clang-format support alpaka#781
- formatted whole codebase
- enabled trailing return types in clang-tidy and applied fix
We need to document in the readme or contribution the command you need to use to format all files. |
Shouldn't that be obvious by the existance of the .clang-format file? Otherwise, what would you prefer? Creating a new contributing.md, add it to readme.md, where there is no developer related content, or install.md where the build instructions are? As for the command, that depends a lot on what shell and operating system you use. I think a developer should find this information for themselves on the web. |
No it is not because the command is not simply
I see we do not have such a file, so I suggest to create it and link it in
You can provide it for linux and windows. MAC should be equal to windows.
You can provide a link to the documentation but give them a copy past line too. |
I added a CONTRIBUTING.md and described briefly how to format. |
Note: We will take this code style for now. It could be we need to update this file again after we agreed for a common style file in ComputationalRadiationPhysics/contributing#33 |