Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline "isSelected" and "unselectItem" don't work with clusters #367

Open
CASandmann opened this issue Jun 9, 2017 · 0 comments
Open

Comments

@CASandmann
Copy link

CASandmann commented Jun 9, 2017

These methods along with setSelection([]) behave incorrectly when the user has clicked a cluster. These methods check for (this.selection && this.selection.index !== undefined) but if the most recent click was on a cluster, selection looks like {cluster: 0} which doesn't pass that condition.

This leads isSelected(clusterIndex) to return false and setSelection([]) and unselectItem([]) to be a no-op and the next time the user calls getSelection() it will return the cluster again. The current workaround is to set timeline.selection.index to a value, but that definitely isn't intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant