Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove include #2

Closed
PatrickvL opened this issue Jul 13, 2024 · 7 comments
Closed

Remove include #2

PatrickvL opened this issue Jul 13, 2024 · 7 comments

Comments

@PatrickvL
Copy link

The log.h include in msf.c seems not needed and if so should be removed (making it somewhat easier to repurpose in xemu for instance)

@PatrickvL
Copy link
Author

Referring to xemu-project/xemu#435 (comment)

@PatrickvL
Copy link
Author

Above applies to master branch

@PatrickvL
Copy link
Author

PatrickvL commented Jul 13, 2024

In cdrom_rewrite branch, cue.h should probably not include disc.h

Edit: for this, move cue_init_disc() over to disc.c

@PatrickvL
Copy link
Author

Perhaps the cue reader could be moved to a separate repo, and used here via a git submodule?

@allkern
Copy link
Owner

allkern commented Jul 15, 2024

Sure, I'll be working towards a separate repo, shouldn't take too long

@allkern
Copy link
Owner

allkern commented Jul 15, 2024

Perhaps the cue reader could be moved to a separate repo, and used here via a git submodule?

Code is up: https://github.com/allkern/cue

@allkern allkern closed this as completed Jul 15, 2024
@PatrickvL
Copy link
Author

I guess one of your next commits in the cdrom_rewrite branch will make use of the extracted tiny cue repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants