Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #7

Open
brean opened this issue Oct 20, 2019 · 7 comments
Open

Update documentation #7

brean opened this issue Oct 20, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers ready

Comments

@brean
Copy link

brean commented Oct 20, 2019

ROS2 uses colcon, the README.md still referes to catkin

@allenh1
Copy link
Owner

allenh1 commented Nov 6, 2019

ROS2 uses colcon, the README.md still referes to catkin

Yes, that's true. I never updated the documentation, since I was hoping to get this sent upstream first.

I'd be more than happy to accept a PR updating the README.md if you have some time!

@brean
Copy link
Author

brean commented Nov 7, 2019

Thanks, I'll create a PR on the weekend.

@allenh1 allenh1 added enhancement New feature or request good first issue Good for newcomers ready labels Nov 13, 2019
@brean
Copy link
Author

brean commented Nov 13, 2019

Sorry, I was a bit to optimistic, I could not get it running on the weekend. I am now working on a setup to run ROS (and ROS2) in docker container for better testing and understand ros2, so feel free to update the documentation yourself, cause this might take some time 😉

@chuan9
Copy link

chuan9 commented Jan 3, 2020

@allenh1 hi, allenh
I'm using dashing version for ros2, and it won't make success after run command "colcon build", will you help update your tutorial here?
the log is bellows:

 warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]

@brean
Copy link
Author

brean commented Jan 3, 2020

@chuan9 that is only a warning, it should still compile. Do you have a longer log and/or do you get another error-message? Also can you provide the exact steps you did or provide your updated Dockerfile?

@chuan9
Copy link

chuan9 commented Jan 4, 2020

@brean Actually, the compilation is ok. I changed some paras and bingo, it works on S1

@allenh1
Copy link
Owner

allenh1 commented Jan 5, 2020

@brean Actually, the compilation is ok. I changed some paras and bingo, it works on S1

Good to hear! Let me know if you need any further assistance.

bednarhonza pushed a commit to fly4future/rplidar_ros2 that referenced this issue Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers ready
Projects
None yet
Development

No branches or pull requests

3 participants