[connector] Fluss sink supports ignore_delete. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loserwang1024
force-pushed
the
delete_strategy
branch
from
dbf95db to
2dc0437
Compare
luoyuxia
reviewed
Dec 27, 2024
| IGNORE_DELETE, | ||
|
|
||
| /** | ||
| * Operate normally based on PK + rowkind, suitable for scenarios that do not involve localized |
There was a problem hiding this comment.
What localized updates means?
There was a problem hiding this comment.
partial update is better, I will update it.
| Row.ofKind(RowKind.INSERT, 2, 3502L, "Fabian"), | ||
| Row.ofKind(RowKind.UPDATE_BEFORE, 2, 3502L, "Fabian"), | ||
| Row.ofKind(RowKind.UPDATE_AFTER, 3, 3503L, "coco"))); | ||
| tEnv.executeSql( |
There was a problem hiding this comment.
We should verify a stream with -D/-U change mode can write to a log sink with ignoreDelete, but currently the source's changelog mode is +I only...
Btw, can we just use the public interface tableEnv.fromChangelogStream to do the testing? I'd like not to introduce an external test jar flink-table-planner since the test jar may change overtime and we may need to adjust our test then..
luoyuxia
reviewed
Dec 27, 2024
| + cdcSourceData | ||
| + "')"); | ||
| tEnv.executeSql( | ||
| "create table sink_test (a int not null, b bigint, c string) with('bucket.num' = '3', 'sink.delete-strategy'='IGNORE_DELETE')"); |
There was a problem hiding this comment.
nit: use ignore_delete since user likely to use lowercase in table option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #251