Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coordinator): Add cypher endpoint info when list_service_status for groot #4382

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Dec 23, 2024

  • Add cypher_endpoint for GrootClient.
  • Rename gremlin_interface to groot_endpoints.

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Copy link
Contributor

github-actions bot commented Dec 23, 2024

Please check the preview of the documentation changes at
https://223f10fe.graphscope-docs-preview.pages.dev

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
lidongze0629
lidongze0629 previously approved these changes Dec 23, 2024
Committed-by: xiaolei.zl from Dev container
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.08%. Comparing base (bbe9295) to head (e30a053).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4382       +/-   ##
===========================================
+ Coverage   34.33%   61.08%   +26.74%     
===========================================
  Files         126      126               
  Lines       13257    13257               
===========================================
+ Hits         4552     8098     +3546     
+ Misses       8705     5159     -3546     

see 59 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0ae5e...e30a053. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants