Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with documentation. #2

Open
glerapic opened this issue Mar 20, 2020 · 1 comment
Open

Conflict with documentation. #2

glerapic opened this issue Mar 20, 2020 · 1 comment

Comments

@glerapic
Copy link

glerapic commented Mar 20, 2020

According to the RVSS whitepaper on section 4C RVSS v1.0 Specification table 4 (page 21) the entry safety reads as follows:
Screenshot from 2020-03-20 12-12-25

so when i run the argument HU on safety i get the following:

alfonso@alias:~$ rvss RVSS:1.0/AV:RN/AC:H/PR:N/UI:N/Y:Z/S:C/C:H/I:H/A:H/H:HU
Error parsing vector: Unknown vector key 'hu' for SafetyImpact

When i run H instead of HU, runs smoothly.

alfonso@alias:~$ rvss RVSS:1.0/AV:RN/AC:H/PR:N/UI:N/Y:Z/S:C/C:H/I:H/A:H/H:H
Base Score:	8.4
Temporal:	8.4
Environment:	8.4

i suggest changing the code to be consistent with the documentation.

@glerapic glerapic changed the title Conflict With available documentation. Conflict with documentation. Mar 20, 2020
@vmayoral
Copy link
Member

Good one. Should be one letter, that's a mistake in the article then.

We should probably reflect this here in the repo by making a changelog/ERRATA section. Thanks for this @glerapic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants