Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(demo): add basic avm-provider #36

Merged
merged 3 commits into from
Aug 28, 2024
Merged

chore(demo): add basic avm-provider #36

merged 3 commits into from
Aug 28, 2024

Conversation

PhearZero
Copy link
Member

@PhearZero PhearZero commented Aug 26, 2024 •
edited
Loading

ℹ Overview

  • adds AVM Provider from algo-models
  • uses AVM Provider to pass messages to Android AVM Provider

Blocked By

  • algo models release

📝 Related Issues

✅ Acceptance:

  • Conventional Commits
  • npm test:cov passes

@PhearZero PhearZero added the task label Aug 26, 2024
@PhearZero PhearZero self-assigned this Aug 26, 2024
@PhearZero PhearZero mentioned this pull request Aug 26, 2024
Merged
2 tasks
@PhearZero PhearZero marked this pull request as draft August 26, 2024 21:16
@PhearZero PhearZero marked this pull request as ready for review August 28, 2024 13:34
@HashMapsData2Value
Copy link
Contributor

Works! LGTM

HashMapsData2Value
HashMapsData2Value approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@HashMapsData2Value HashMapsData2Value left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested out the changes and they work.

@PhearZero PhearZero merged commit 952a554 into develop Aug 28, 2024
2 checks passed
@PhearZero PhearZero deleted the chore/avm-provider-ENG-510 branch August 28, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HashMapsData2Value HashMapsData2Value HashMapsData2Value approved these changes

@ehanoc ehanoc Awaiting requested review from ehanoc

Assignees

@PhearZero PhearZero

Labels
task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhearZero @HashMapsData2Value