Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/remove-hardcoded-demo-credentials #23

Merged
merged 1 commit into from
Jun 3, 2024
Merged

chore/remove-hardcoded-demo-credentials #23

merged 1 commit into from
Jun 3, 2024

Conversation

kylebeee
Copy link
Collaborator

@kylebeee kylebeee commented Jun 3, 2024

ℹ Overview

  • moved demo turn server username/credential into docker env

✅ Acceptance:

  • Conventional Commits

PhearZero
PhearZero reviewed Jun 3, 2024
View reviewed changes
.env.docker Outdated Show resolved Hide resolved
sites/dapp-ui/src/components/ConnectModal.tsx Outdated Show resolved Hide resolved
@kylebeee kylebeee force-pushed the chore/remove-hardcoded-demo-credentials branch from d530925 to 12101a0 Compare June 3, 2024 23:32
@PhearZero PhearZero self-requested a review June 3, 2024 23:44
PhearZero
PhearZero approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhearZero PhearZero added the task label Jun 3, 2024
@PhearZero PhearZero merged commit 1008cf1 into develop Jun 3, 2024
2 checks passed
@PhearZero PhearZero deleted the chore/remove-hardcoded-demo-credentials branch June 3, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhearZero PhearZero PhearZero approved these changes

Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylebeee @PhearZero