Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic filters #28

Open
robdmoore opened this issue Mar 19, 2024 · 2 comments · May be fixed by #45
Open

Dynamic filters #28

robdmoore opened this issue Mar 19, 2024 · 2 comments · May be fixed by #45
Labels
enhancement New feature or request

Comments

@robdmoore
Copy link
Contributor

robdmoore commented Mar 19, 2024

Support the ability to add filters dynamically based on the information retrieved in blocks (potentially re-running those filters in the block that the new filter was discovered in?).

Need to figure out if indexer catchup mode can be supported by this or not - it would be tricky to do, but may be possible.

Requires #27

We will need to include a filter persistence mechanism similar to watermarking.

Idea: either allow entire filters to be dynamically added, or allow a static set of filters to reference a "dynamic filter value", which resolves to an named array value that can be looked up.

Question: do we re-run the modified filter for the current block or does it take effect from the next block (simpler).

@robdmoore robdmoore added the enhancement New feature or request label Mar 19, 2024
@robdmoore robdmoore linked a pull request Mar 29, 2024 that will close this issue
@PhearZero
Copy link
Member

PhearZero commented Sep 18, 2024

Was looking into this today a bit, this would be the main blocker for governance transactions.

  • On Payment Transaction With Governance Note
    • Lookup Account Balance and compare against Commitment
    • Update AccountState
  • On Dynamic Account Watch List
    • Lookup AccountState and Balance
    • Compare state to Balance
    • Update AccountState

I couldn't think of any other way than Follower Mode + Dynamic Filters in order to solve the problem. We can easily orchestrate the state in the node and get the current balances to validate the payment transaction commitment. Not sure about how the filter will react to it

@robdmoore
Copy link
Contributor Author

I've got it mostly implemented in #45 - just needed final polish, but been distracted since then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants