Make SettingsManager extendible #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would allow us to implement our own SettingsManager that supports replicas. algolia#348
maciekpaprocki
changed the title
DevinCodes
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would allow us to implement our own SettingsManager that supports replicas.
#348
Describe your change
Making class final removes the option for us to use DI to replace it with our own settings manager.
Although the correct solution would be to implement interface and use that in DI, this will be braking change, while removing final shouldn't cause any issues and will make it extendible.
What problem is this fixing?
Lack of extendability of settings manager service, which makes it impossible to reimplement it by devs to fix replica issue.