Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade bundle's abstraction level #239

Open
proArtex opened this issue Jun 5, 2018 · 1 comment
Open

Downgrade bundle's abstraction level #239

proArtex opened this issue Jun 5, 2018 · 1 comment

Comments

@proArtex
Copy link

proArtex commented Jun 5, 2018

  • Symfony version: 4
  • Algolia Search Bundle version: 3.1.2
  • Algolia Client Version: 1.25.1
  • Language Version: ru

Description

Bundle has too high abstraction level by deciding which index to use with search or index ops. Any entity may be placed in different indexes (e.g. different order). Same problem taking place in discriminated doctrine entities, that could be indexed separately or all together.

My suggestion is to downgrade abstraction level for IndexManager and let developers write their own SearchIndexerSubscribers, to pass required indexes and actions.

@julienbourdeau
Copy link
Contributor

Hi @proArtex, thanks for your feedback.
I would definitely like to add the possibility to index multiple entities to one index and send one entity to multiple index. I currenlty haven't found a good way to do so but I'm definitely open to any idea.

Could you share more details to what you have in mind about

let developers write their own SearchIndexerSubscribers, to pass required indexes and actions

I think it's doable with the current version, I'd like to give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants