-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with upcoming Grafana v10.0 ? #411
Comments
Unfortunately, it does not look like it. Best bet is to migrate Edit - to Flow Panel which is the more scalable and fast Flowcharting alternative. Edit |
Same as my situation.. |
Please migrate it |
We need it - please fix this great plugin ! 👍 |
i believe this is an option to enable support of Angular in 10
|
@thanissi Yes that should work for Grafana 10 but it is to be removed in Grafana 11. |
of not migrating from angular, will this plugin die slowly ? |
Hi @algenty |
I think it's safe to say the project has been abandoned. Either the project should be forked or migrate to Grafana Canvas or some other plugin that can do the job. |
I think it's a huge unrealistic bet that an abandoned project is going to be migrated to an entirely new web framework. +1 because I'd love to still use my dashboards with this epic plugin. @algenty would be great if we could get info if this project is dead. |
Flowchart is a must and will be a pity if the project is abandoned... |
Such a shame. I love this plugin. I use it for a network Weathermap with Prometheus data feeding it. I suppose I will need to learn Canvas and migrate :/ |
Looks like we can upgrade grafana until v11 arrives next year (https://grafana.com/docs/grafana/latest/developers/angular_deprecation/):
|
Just tested Grafana 10.2, it breaks flowcharting, there seems to be an issues with reading metrics. EDIT: If any series returns no values, the flowchart will not evaluate rules and no colours appear in the flowchart. If there are any develepors that could whip up a fix that would at least gives us time to run until the final death of angular. @teguhsatria892 @pauljones0 @icl-rocketry |
Hi xkilian, Are the measurements correctly shown with panel->inspect->data, or are metric names different than before? Kind regards, |
Looks like the mime-type text/html is incorrect for the stylesheet common.css and therefore denied since strict mime-type checking is enabled.
Get TypeApp for Android
…On 27 Oct 2023, 17:41, at 17:41, xkilian ***@***.***> wrote:
In the inspect panel->Inspect->Data, the data is there, I do not think
I am running into the same problem. Here is the web console data from
Chrome:
![image](https://github.com/algenty/grafana-flowcharting/assets/1302719/c0001fac-6842-432d-8453-c3122d00d5bb)
--
Reply to this email directly or view it on GitHub:
#411 (comment)
You are receiving this because you commented.
Message ID:
***@***.***>
|
Yeah, but Firefox has the same functional issue and it does not have strict checking. |
Ok, found it. If a time series returns null. (no result) All rules are not evaluated and no colours appear on the flowchart. This is really problematic, as I use extensively the ALERTS{} metrics in my flowcharts, which are often null when there are no active alerts. The way grafana passes empty series to the plugin must have changed. |
Minor thing, the colour stacking seems to be evaluating a little differently in 10.2 versus 9.2. (my production environment), but it is possible to correct so that they stack appropriately by playing with the rule levels. |
Please migrate it. |
I just tried |
@bijwaard My collegue fixed the issue of Flowcharting compatibility with 10.2, the way data was passed from grafana for empty series changed. A fork of Flowcharting will be posted to github and maybe we will include some minor fixes from other branches. |
Can't wait for this fix... |
Hi @xkilian, great news! Hope someone also finds some time to port Angular to React to extend the plugin munch longer;-) Kind regards, |
@bijwaard Any idea on when this fork will be posted ? |
Awesome… Please share the link when is ready:) |
Yeah, kind of busy on urgent deliverables. The plan is to provide a fork with this fix and a fix for the url/save problem when editing draw.io image. |
Well, happy campers. |
Thank you ! I will try this out in our sandbox environment over the next week ! |
hi @xkilian i tried upgrading to your fork, it works perfectly except tooltip doesn't show, when i click edit and save on graph it start showing, when i refresh the page the tooltip doesn't show again. Can you take a look? |
created a petition https://chng.it/FVjYwTP27D please sign in |
After i upgrade, it works but grafana reports error '...path=/d/acea34ea-7fbf-4f9e-abd6-7a989bdc2c73/img/lib/clip_art/networking/Bridge_128x128.png... referer="https://localhost:3000/d/acea34ea-7fbf-4f9e-abd6-7a989bdc2c73/img/lib/clip_art/networking/Bridge_128x128.png...handler not found' in the copy of demo 'Flowcharting - Network diagram'. But it works for a copy of demo 'FlowCharting - Hierarchical state level'. Is there any place where I can configure it so that it can use the correct image URL? |
For those who missed it, a new plugin very similar to flowcharting (based off draw.io) has been created: flow-panel Canvas will also have a few usability enhancements that should bring it closer to what is required to replace flowcharting for a few more use cases. Things are looking up. @bijwaard |
Nice, 10 sec glance and it looks very viable. |
Flow-panel looks cool, they seem to have a nice separation between rules file (yaml), globals (yaml) and visualisation (svg), but will need an webserver to host the files. Editing all the drawio IDs becomes a nightmare in complex diagrams, I would rather use a custom data-item like "name" and preferably with recursive paths for grouped objects, e.g. reference group/object for object contained within group. |
Thanks for the feedback. re the webserver, that's optional. You can just paste the svg/yaml file content direct into the panel. re the ids. I thought it just used the same ids that the flowcharting panel did. You should be able to export your flowcharting svg into the draw.io app. resave with the svgdata plugin installed and have all the same ids as you had before. Albeit they'll now have a 'cell-' preamble on them but that's taken care of in the yaml cellidpreamble field. I'm not saying it's the best solution, just that I believe it treats ids the same way flowcharting did. Really do recommend using the draw.io app to edit the ids. it's only a right-click->select->doubleclick->apply->apply for each one. And once they're done they're done :) |
Thanks Andy, The IDs was something that was discussed here in flowcharting as well, it could be made selectable whether to use IDs, another attribute, and/or group/child hierarchy using e.g. the "name" attribute. There seem to be some restrictions on symbols that can be used in IDs, my old dashboard uses ":" as a separator within IDs like "CT:L1" that need to be escaped as e.g. "CT\:L1" in YAML to bind them to actions. Guess we can take further discussion in issue tickets in the flow_panel github page |
Hi guys! |
Yes. It is grossly equivalent. |
|
The main difference of Flow panel is that the rules are specified in the YAML language. This language is quite simple and is split in an global config (siteConfig) that can be reused for multiple panels and a panel specific one (panelConfig) that applies to the current panel. You can either use a hyperlink to a configuration file or type the YAML configuration in the box. There are example configurations with descriptions in the README |
Is it possible to integrate with "PRTG" DataSource? |
Don't know the PRTG datasource, but in general panel plugins are mostly independent of the datasource type. Just try it. |
Hi, |
I have converted one of my flowcharting flows, it is different since the rules are specified in panel YAML file, and there are examples available to help you. The site configuration helps to configure thresholds in one place instead of repeating them everywhere. For a simple flow it may take some extra time since you need to get familiar with the syntax, for multiple rules it goes faster once you get the hang of it. There are example YAML filles available in the documentation. |
Thanks for your reply @bijwaard |
Luckily, Flowcharting is still working in Grafana v11.0. |
which version did you use? It does not work for me in v11 |
I am using Grafana v11.1.3 and Flowcharting 0.91. Please check https://grafana.com/docs/grafana/latest/developers/angular_deprecation/ and note "In Grafana 11, which will be released in preview in April 2024 and generally available in May, we will change the default behavior of the angular_support_enabled configuration parameter to turn off support for AngularJS based plugins. In case you still rely on AngularJS-based plugins developed internally or by the community, you will need to enable this option to continue using them." Update 10/09/2024: after updating to Grafana 11.2 this occurs: "an unexpected error happened mi.constructor is undefined“. I was not able to fix it so I reverted back to 11.1.3 |
An idea could be to ask ChatGPT to convert this plugin from AngularJS naar React (v5). |
The flowcharting grafana plugin is replaced by the Flow grafana plugin. |
Hi,
in pre-relase notes for Grafana 10, it is stated that support for Angular is turned off by default. Hence any plugin not migrated away from Angular will fail to work.
Are there any plans to move flowcharting plugin from Angular framework ?
The text was updated successfully, but these errors were encountered: