feat(amount): drop vars, add props #753
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
Artess999,
aso1datov,
aweppc,
denisx,
FenkoAlex,
Heymdall,
IBelyaev,
NatalyaZ,
raylyanway,
stepancar,
Vorozhtsoff and
YozhEzhi
NatalyaZ
approved these changes
Jul 16, 2021
aso1datov
approved these changes
Jul 16, 2021
aleksey-ilin
approved these changes
Jul 16, 2021
reme3d2y
commented
Jul 16, 2021
| /** | ||
| * Управление жирностью | ||
| */ | ||
| bold?: 'full' | 'major' | 'none'; |
There was a problem hiding this comment.
Можно заменить на | false. Но хз)
packages/amount/src/component.tsx
Outdated
| @@ -14,6 +14,8 @@ export const Amount: React.FC<AmountProps> = ({ | |||
| minority, | |||
| currency, | |||
| view = 'default', | |||
| bold = 'major', | |||
| transparentMinor = true, | |||
There was a problem hiding this comment.
А может по дефолту bold=none/transparentMinor=false?
There was a problem hiding this comment.
я старался сделать так, чтобы ничего нигде не изменилось
SiebenSieben
approved these changes
Aug 18, 2021
|
Собрана новая демка. |
reme3d2y
force-pushed
the
feat/amount-styling
branch
from
bcf85fa
to
1fd54ab
Compare
|
Собрана новая демка. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Даем возможность удивлять пользователя циферками денег.
Вопрос
Т.к. переменные дропнутся — это должна быть мажорка. Но судя по моим раскопкам это зааффектит только клик, а у них есть обертка. Поэтому предлагаю не катить мажорку и одновременно с мержем принести ПР в композиты и поменять там дефолтные значения.
Для чего это все