Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten clearfix #47

Closed
KittyGiraudel opened this issue Dec 2, 2014 · 2 comments
Closed

Shorten clearfix #47

KittyGiraudel opened this issue Dec 2, 2014 · 2 comments

Comments

@KittyGiraudel
Copy link

Any reason you still use an old version of the micro-clearfix: https://github.com/alexwolfe/Buttons/blob/master/scss/_mixins.scss#L39-L53?

You could switch to:

.clearfix::after {
  content: '';
  display: table;
  clear: both;
}
@alexwolfe
Copy link
Owner

Nope, this was just legacy code so no priority was placed on switching it. We only use it in one place in the entire lib (button groups). We can def use the shorter version.

Thanks for look through the code, really appreciate your attention to detail and an extra set of eyes! 👍

@roblevintennis
Copy link
Collaborator

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants