Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grep command for TODOs #7

Open
jibran opened this issue May 24, 2016 · 2 comments
Open

Add grep command for TODOs #7

jibran opened this issue May 24, 2016 · 2 comments

Comments

@jibran
Copy link

jibran commented May 24, 2016

Add grep command to pre commit script to make sure there is no @todo left for this issue so when https://www.drupal.org/node/2577827 is fixed grep -inr 2577827 core/ should return nothing.

@alexpott
Copy link
Owner

This is problematic because there are valid @todo in our code. So checking this would cause a fail. I think a better thing would be to add a @todo checker to coder that checks the format and ensures it has a link to a drupal.org issue.

@jibran
Copy link
Author

jibran commented May 21, 2017

This is problematic because there are valid @todo in our code.

How can be a @todo valid if it is related to the same issue which is going to be committed? Either we need a fix for that or a new issue.

I think a better thing would be to add a @todo checker to coder that checks the format and ensures it has a link to a drupal.org issue.

Coder already checks the format but not all the @todo can be fixed on drupal.org sometimes it links to upstream library and sometimes it links to a PHP issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants