You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add grep command to pre commit script to make sure there is no @todo left for this issue so when https://www.drupal.org/node/2577827 is fixed grep -inr 2577827 core/ should return nothing.
The text was updated successfully, but these errors were encountered:
This is problematic because there are valid @todo in our code. So checking this would cause a fail. I think a better thing would be to add a @todo checker to coder that checks the format and ensures it has a link to a drupal.org issue.
This is problematic because there are valid @todo in our code.
How can be a @todo valid if it is related to the same issue which is going to be committed? Either we need a fix for that or a new issue.
I think a better thing would be to add a @todo checker to coder that checks the format and ensures it has a link to a drupal.org issue.
Coder already checks the format but not all the @todo can be fixed on drupal.org sometimes it links to upstream library and sometimes it links to a PHP issue.
Add grep command to pre commit script to make sure there is no @todo left for this issue so when https://www.drupal.org/node/2577827 is fixed
grep -inr 2577827 core/
should return nothing.The text was updated successfully, but these errors were encountered: