Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: bulloak.toml config file #38

Open
PaulRBerg opened this issue Sep 28, 2023 · 3 comments
Open

Feature request: bulloak.toml config file #38

PaulRBerg opened this issue Sep 28, 2023 · 3 comments
Labels
Feat New feature or request Uphill Needs research before being implemented

Comments

@PaulRBerg
Copy link
Contributor

PaulRBerg commented Sep 28, 2023

Things that I would like to configure (and which Bulloak would apply to all Solidity code generated via scaffold):

It would be nice if these settings could be kept in foundry.toml somehow, but I don't think Foundry allows custom configs.

I'm sure @mds1 and future users will find other use cases with this config file.

@mds1
Copy link
Contributor

mds1 commented Sep 29, 2023

I'd suggest requiring the config to just live in foundry.toml to avoid needing new config files for each tool. See foundry-rs/foundry#5866 for my suggestion on how this would look

@alexfertel alexfertel added Feat New feature or request Uphill Needs research before being implemented labels Sep 30, 2023
@alexfertel
Copy link
Owner

alexfertel commented Oct 5, 2023

Tbh, I have conflicting feelings over this one. I totally agree with having a config file. However, if the only advantage of having the config inside foundry.toml is having one less file in the project, I'd rather use a separate bulloak.toml. I know people have hated having way-too-many config files historically, but I don't really mind it.

The rationale for a separate bulloak.toml is:

  • Friendlier for first-time users:
    • Someone who hasn't used bulloak before would not expect it to be configured in a foundry.toml.
    • Syntax is a bit more complex. Users need to be aware of the proposed external (or whatever is chosen) and the config will be surrounded by unrelated configs.
  • Parsing is simpler. A trivial amount, but nonetheless simpler.
  • Stay decoupled from Foundry. This is not a strong argument, bulloak is already coupled to Foundry, however, that might change in the future.
  • Generating a file with the default config is simpler that modifying a foundry.toml.

That being said, I'm not strongly opinionated.

@PaulRBerg
Copy link
Contributor Author

I know people have hated having way-too-many config files historically, but I don't really mind it.

Me neither!

bulloak is already coupled to Foundry, however, that might change in the future.

TBH I can see Bulloak used for other blockchain programming languages + paradigms other than crypto.

The rationale for a separate bulloak.toml

Agree with all points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat New feature or request Uphill Needs research before being implemented
Projects
None yet
Development

No branches or pull requests

3 participants