Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

play_sounds shouldn't ship with media files #3

Open
alexdelorenzo opened this issue Nov 12, 2021 · 1 comment
Open

play_sounds shouldn't ship with media files #3

alexdelorenzo opened this issue Nov 12, 2021 · 1 comment

Comments

@alexdelorenzo
Copy link
Owner

The resulting wheel is ~7.5MB. A play_sounds==0.5.0 wheel without the media is only 8.7 KB.

This project shouldn't ship with media files. Maybe break them into an optional, or separate, package.
@jessebot
Copy link

think this was done in 73ffa5f, so this issue can probably be closed.

Thanks for this project btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessebot @alexdelorenzo