Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it work in angular 4? #22

Open
echorohit opened this issue Aug 3, 2017 · 9 comments
Open

Does it work in angular 4? #22

echorohit opened this issue Aug 3, 2017 · 9 comments

Comments

@echorohit
Copy link

As directive is no more a part of @component declaration the directive way is not working.

@dalilagauge
Copy link

I'm using angular 4 too. Did you resolve this problem?

@echorohit
Copy link
Author

@dalilagauge No. I am building my own!

@dalilagauge
Copy link

dalilagauge commented Sep 20, 2017

@echorohit Could you share your solution, please?

@LenonLopez
Copy link

LenonLopez commented Sep 23, 2017

currently developing the angular 4 solution. hoping to pull request and merge here soon. @dalilagauge

just pushed the angular 4 solution to npm : https://www.npmjs.com/package/angular-notice. Hoping once Alex responds we can merge the projects. The repo is also on my github.

@dalilagauge
Copy link

dalilagauge commented Sep 29, 2017

Thank you @LenonLopez!
Is your project merged? How can I use?

@LenonLopez
Copy link

@dalilagauge
Unfortunately it is not merged but you can go to the npm page for the package i created and follow directions there.

I also have a new repo:
https://github.com/LenonLopez/angular-notice

If you can any questions please go there and open an issue. I will be more than happy to develop more features you need.

@WitoldSlawko
Copy link

@LenonLopez
Hello. I was trying to apply your solution but an error appeard:

ERROR Error: Uncaught (in promise): Error: No provider for NativeNotificationService!
Error: No provider for NativeNotificationService!

I followed the instructions. My angular version is 4.4.4.

Please help.

@WitoldSlawko
Copy link

Ok I got the solution, the line:

import { NativeNotificationService } from 'angular-notice/lib/native-notification.service';

should also be included in app.module.ts and NariveNotificationService should be placed in @NgModule's provider array.

Now it works. Awesome solution for @LenonLopez for Angular 4 ! Many thanks !

@alexcastillo
Copy link
Owner

@LenonLopez Mind submitting a PR to this project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants