Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good First Issue: Store an event history for all previously submitted eventBridge events #239

Open
mansurpasha opened this issue May 11, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mansurpasha
Copy link
Contributor

Why: When opening the Event Injection modal for a particular eventBus, the tool populates each field (source, detail type, and detail) with the last values used for that eventBus. Allowing all events to be saved, similar to the command history in the terminal, will allow users to quickly test multiple events without having to type the same parameters repeatedly.

Expected Behaviour:

  • when using the event injection modal, users can use keypresses to cycle through all events previously injected on that bus

Scope Limit:

  • this should at least work for the current session of the tool
  • In a future issue/pr, this could be extended to include a persistent event history, by use of a event history file, to allow users to quit the tool and still access previously injected events on reopening the tool

Changes needed:

  • When storing events, change the previous event dictionary to map to a list of events instead of a single instance here
  • Modify the modal to access the previously submitted event from an array of objects here
  • Create a new function to use the list of events to set the text value of all the textboxes using textboxes[i].setContent(Field). It may help to use this for-loop for some inspiration
  • Trigger this function using a eventInjectLayout.key() event

image

@mansurpasha mansurpasha added enhancement New feature or request good first issue Good for newcomers labels May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant