Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated io/ioutil #341

Closed
wants to merge 2 commits into from
Closed

Remove usage of deprecated io/ioutil #341

wants to merge 2 commits into from

Conversation

SuperSandro2000
Copy link

No description provided.

@matfax
Copy link
Contributor

matfax commented Oct 15, 2023

Deprecated: As of Go 1.16, the same functionality is now provided by package [io](https://pkg.go.dev/io) or package [os](https://pkg.go.dev/os), and those implementations should be preferred in new code. See the specific function documentation for details.

Source: https://pkg.go.dev/io/ioutil

Copy link
Contributor

@matfax matfax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only guessing why this isn't merged yet. Either due to the empty body or because of the reformat in mapper.go.

mapper.go Outdated Show resolved Hide resolved
mapper.go Outdated Show resolved Hide resolved
mapper.go Outdated Show resolved Hide resolved
mapper.go Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Author

because of the reformat in mapper.go.

That is standard go fmt which got introduced in 1.20 or 1.21 for comment blocks. I can revert it but go will put it back when formatting.

@abhinav
Copy link
Contributor

abhinav commented Dec 10, 2023

Superseded by #403.
Can probably be closed.

@alecthomas alecthomas closed this Dec 10, 2023
@SuperSandro2000 SuperSandro2000 deleted the ioutil branch December 11, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants