-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add native context support to Run methods #144
Comments
Ah that is not a bad idea. I can't recall if Kong will allow that default binding to be overridden? |
I forgot to say, I would definitely appreciate a PR for this, thanks :) |
@carnott-snap I'd be happy to see this contribution too: I've arrived here via #48 and it's not exactly a very elegant workaround – a native |
Further to this, what would the expected behaviour be if the user subsequently bound a |
A |
I am aware of what it is... I meant if Kong automatically injects a |
I think Kong could add a context to handle OS signals so the application can gracefully shutdown. |
Currently you can manually bind a
context.Context
to akong.Context
, see #48, but this is not as turnkey as I would have hoped. Would it be possible to add an automatic bind, assuming one is not passed to override, forcontext.Context
that is cancelled whenkong.Context.Run
returns?Happy to contribute such a fix, but I thought I would ask if this was wanted first.
The text was updated successfully, but these errors were encountered: