Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qibuild add-config --host lets you create a qibuild.xml with several host configs (which qibuild does not support) #105

Open
sbarthelemy opened this issue Dec 20, 2016 · 0 comments

Comments

@sbarthelemy
Copy link

sbarthelemy commented Dec 20, 2016

Seen on qibuild 3.11.6 from pip.

$ qibuild add-config foo --host
$ qibuild add-config bar --host
$ cat ~/.config/qi/qibuild.xml
<qibuild version="1">
  <defaults>
    <env />
    <cmake />
  </defaults>
  <config host="true" name="bar">
    <env />
    <cmake />
    <profiles />
  </config>
  <config host="true" name="foo">
    <env />
    <cmake />
    <profiles />
  </config>
</qibuild>

Since two config are marked "host" qibuild make-host-tools picks one arbitrarily, possibly the wrong one.

A workaround is to use qibuild set-host-config.

$ qibuild set-host-config bar
$ cat ~/.config/qi/qibuild.xml
<qibuild version="1">
  <defaults>
    <env />
    <cmake />
  </defaults>
  <config host="true" name="bar">
    <env />
    <cmake />
    <profiles />
  </config>
  <config name="foo">
    <env />
    <cmake />
    <profiles />
  </config>
</qibuild>

I think the proper fix is to avoid this "only one host config requirement". As explained in issue #81.
This new bug is one more clue that the current design is flawed.

Note: the current code is quite easy to understand:

add_build_config creates the config (host or not), then add_config adds it without checking for host config collision.

On the contrary set_host_config does check.

@sbarthelemy sbarthelemy changed the title qibuild add-config --host lets you create a config with several host configs (which qibuild dos not support) qibuild add-config --host lets you create a qibuild.xml with several host configs (which qibuild does not support) Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant