refactor(rpc): add rpc crate #375
Conversation
dancoombs
requested review from
dphilipson,
0xfourzerofour and
alex-miao
as code owners
| @@ -3,7 +3,7 @@ use std::time::{Duration, Instant}; | |||
| use jsonrpsee::{helpers::MethodResponseResult, server::logger::Logger}; | |||
|
|
|||
| #[derive(Clone)] | |||
| pub struct RpcMetricsLogger; | |||
| pub(crate) struct RpcMetricsLogger; | |||
There was a problem hiding this comment.
Can you explain why you choose to use pub(crate) here? My understanding (correct me if I'm wrong) is that these wouldn't have been exposed outside the crate anyways since they're not visible in lib.rs, so is this being used as documentation? Should we have guidelines for when to use pub(crate)?
There was a problem hiding this comment.
This is enforced by the unreachable_pub lint, which will reject this if its marked as pub but isn't exposed outside of the crate. I actually think this is a reasonable lint as this makes it very clear that this code is only used within the crate. That gives it slightly less of a priority when it comes to API design and documentation. Also, the interwebs is saying that if you use pub(crate) dead code will get marked and can be removed.
dancoombs
force-pushed
the
danc/builder-crate
branch
from
20e195c
to
78cf1af
Compare
dancoombs
force-pushed
the
danc/rpc-crate
branch
from
b516c2d
to
7e3b92f
Compare
No description provided.