Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pool): add pool crate #373

Merged
merged 1 commit into from
Sep 18, 2023
Merged

refactor(pool): add pool crate #373

merged 1 commit into from
Sep 18, 2023

Conversation

dancoombs
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very solid PR, great cleanup just a couple inline questions

Makefile Outdated Show resolved Hide resolved
crates/pool/src/chain.rs Show resolved Hide resolved
crates/pool/src/mempool/pool.rs Show resolved Hide resolved
crates/sim/src/estimation/estimation.rs Outdated Show resolved Hide resolved
crates/sim/src/simulation/tracer.rs Outdated Show resolved Hide resolved
@0xfourzerofour
Copy link
Collaborator

and conflicts but that is obv

@dancoombs dancoombs changed the title refactor(sim): create the sim crate and move code refactor(pool): add pool crate Sep 18, 2023
Base automatically changed from danc/sim-crate to main September 18, 2023 20:51
@dancoombs dancoombs merged commit 8be3699 into main Sep 18, 2023
5 checks passed
@dancoombs dancoombs deleted the danc/op-pool-crate branch September 18, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants