Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Return UserOpReceipt after waiting for UserOpTransaction #1137

Open
dospore opened this issue Nov 8, 2024 · 1 comment
Open

FR: Return UserOpReceipt after waiting for UserOpTransaction #1137

dospore opened this issue Nov 8, 2024 · 1 comment

Comments

@dospore
Copy link

dospore commented Nov 8, 2024

Is your feature request related to a problem? Please describe.
I'd like to be able to check the userOpReceipt after waiting for the transaction. Instead of having to call eth_getUserOperationReceipt the receipt could be returned as well since its already queried.

Describe the solution you would like
Im happy to put in a PR for this since I have the patch using patch-patch but thought I'd hold off to see if its even something you'd consider. I would like access to the entire userOpReceipt so that I can check the status code of the innerOp and handle successful transactions reverting inner userOps. As a general improvement I am wondering why the entire txn payload is not returned since then you can do a lot more with it.

Describe alternatives you have considered
I could query eth_getUserOperationReceipt but it adds unnecessary latency.

Additional context
waitForUserOperationTransaction already has queried the receipt I just thought it makes sense to return it alongside the txn.

@moldy530
Copy link
Collaborator

oh I knew there was something we meant to include in the v4 changes and it was this exact change!

Unfortunately, changing the API for waitForUserOperationTransaction would make this a breaking change. something we could do is add another action on the client called waitForUserOperationReceipt which would allow you to do this more easily. Happy to accept a PR for this if you've already got something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants