Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regexp was missing case #18

Open
haykgh opened this issue Aug 9, 2019 · 2 comments
Open

Regexp was missing case #18

haykgh opened this issue Aug 9, 2019 · 2 comments

Comments

@haykgh
Copy link

haykgh commented Aug 9, 2019

Dear contributors,

please replace following regular expression in Parser.php:
'/data:([a-zA-Z-\/+]*)([a-zA-Z0-9-_;=.+]+)?,(.*)/'
with
'/data:([a-zA-Z-\/+.]*)([a-zA-Z0-9-_;=.+]+)?,(.*)/'
to handle cases like application/vnd.ms-excel.

This is also missed test case 5.

Thanks.

@joeyhub
Copy link

joeyhub commented Nov 27, 2019

Also...

'/^data:

A url can contain a data url.

jygaulier added a commit that referenced this issue Nov 28, 2019
@gnutix
Copy link
Contributor

gnutix commented Mar 31, 2020

@jygaulier Should this issue be closed ? (the last comment about '/^data: was not implemented AFAIK)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants