Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from phpunit 5.7 to 7.3 and php 5.5 to 7.1 #26

Open
5 tasks
jens1o opened this issue Aug 7, 2018 · 5 comments
Open
5 tasks

Move from phpunit 5.7 to 7.3 and php 5.5 to 7.1 #26

jens1o opened this issue Aug 7, 2018 · 5 comments

Comments

@jens1o
Copy link
Contributor

jens1o commented Aug 7, 2018

preparing for PHP-FFMpeg/PHP-FFMpeg#412

--

  • Set declare(strict_types=1); in every file and fix any type-converting struggles.
  • Use scalar type hints, null type hints and return type values(even void) in any classes.
  • Check whether we have any workarounds for older php versions
    • Remove them if they aren't necessary anymore.
  • Convert any array(...) to [...]
@jens1o jens1o changed the title Move from phpunit 5.7 to 6.3 and php 5.5 to 7.1 Move from phpunit 5.7 to 6.5 and php 5.5 to 7.1 Aug 7, 2018
@jens1o
Copy link
Contributor Author

jens1o commented Aug 7, 2018

maybe we can update to PHPUnit 7, too.

@jens1o
Copy link
Contributor Author

jens1o commented Aug 7, 2018

26b9c3c

@jens1o jens1o changed the title Move from phpunit 5.7 to 6.5 and php 5.5 to 7.1 Move from phpunit 5.7 to 7.3 and php 5.5 to 7.1 Aug 7, 2018
@peter279k
Copy link

Is any updated commit for this issue?

@jens1o
Copy link
Contributor Author

jens1o commented Jul 6, 2019

No, not yet. However, if you want to help out, you're welcome to file a Pull Request. Personally I should have time again after the final exam on Monday for ~8 weeks then.

@rickmills
Copy link

Any plans to merge in the pull request from August above? This is starting to cause massive headaches now that everyone else has updated to Symfony 4 packages.

@jygaulier @nmaillat @jens1o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants