-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Some) Icons in note titles are not rendered. #118
Comments
Sorry, I don't understand. Iconize works fine in both note and title: https://share.note.sx/fx9o5mt6#g5Lqk27DRYjca5+iBywOfc4Pbt/mJZksYWCL5TFOyos Did you follow the troubleshooting steps that were shown when you went to create this issue? |
Here's an example: https://share.note.sx/zasaru7u#JHlvkSLYoLRiS+N8xKU0FrT9Es3jnBJJT/SxCbo40Z8 |
Yes, but did you follow the troubleshooting steps? I assume the issue is that you need to force the CSS to upload. If not, can you also try in a Sandbox vault? I can confirm that Iconize icons work fine in a link also: https://share.note.sx/kugy229r#FtP3DPh0AGq/Fbz2gqA4kW+XZXfb3tB8uFvsOXsyDdk |
Yes, I've done the force re-upload and can confirm the CSS step is happening: However, it's still rendering the HTML as plain-text instead of being interpreted to produce the SVG icon. Here's reproduction in a fresh sandbox environment with both Iconize and ShareNote installed and force re-uploaded as well: https://share.note.sx/srdtnx35#Mqh7lV5JcsSv7JksDj5s8jRRX9ceKll94IZBTy2tJPI |
I can see that some icons work and some do not: https://share.note.sx/kugy229r Not sure what the issue is, but I will leave this issue open in the meantime. |
Ah how interesting. Thanks for confirming, look forward to the eventual fix. I tried a few more icons from differing packs to see if it was based on that, haven't found a dividing line yet, maybe some additional details for you here to aid in debugging: https://share.note.sx/srdtnx35#Mqh7lV5JcsSv7JksDj5s8jRRX9ceKll94IZBTy2tJPI Side note, great extension, love! |
Leveraging a plugin like iconify allow for addition of SVG icons which then fail to render in shared notes, example:
Perhaps best to add a plugin option with a list of classes that are allowed to pass through as direct HTML to support this (via "iconize-icon-in-link") and future needs?
The text was updated successfully, but these errors were encountered: