Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

akka-projection-slick Scala 3 artifact/support/cross-build #1057

Closed
chris-arrakis opened this issue Oct 30, 2023 · 7 comments
Closed

akka-projection-slick Scala 3 artifact/support/cross-build #1057

chris-arrakis opened this issue Oct 30, 2023 · 7 comments
Milestone

Comments

@chris-arrakis
Copy link

Short description

Slick itself is now published for Scala 3, so I'm guessing it's possible to get this library there too now? I'm a little new to the Akka ecosystem, but from my attempts I couldn't find a way to use akka-projection-slick in Scala 3 due to conflicts from its dependencies.

Details

I'm not sure if there's much to change in the library. Slick was of course blocking the upgrade because it uses macros, but now that it's been ported I don't see anything this this code that raises big flags (from my admittedly pretty Scala-2-inexperienced perspective). But I'm not sure if all the dependencies are also available for Scala 3 or can be pulled in from 2.13 in a non-conflicting way to a project based on e.g. com.typesafe.akka:akka-actor-typed_3.

From a brief look I'm guess this configuration will need to be updated: https://github.com/akka/akka-projection/blob/main/build.sbt#L59 to include .settings(Scala3.settings) to add the cross build.

Not sure what other steps are needed though!

@johanandren
Copy link
Member

If you want to give it a shot a PR is welcome!

@patriknw
Copy link
Member

Somewhat related to akka/akka-persistence-jdbc#775

@PerWiklander
Copy link

This is now the last dependency blocking our team from adopting Scala 3 without a major rewrite of our projection code.

Slick is published for Scala 3.
akka-persistence-jdbc is published for Scala 3.

What needs to be done here and what can I help with?

@johanandren
Copy link
Member

johanandren commented Apr 2, 2024

It has already been merged and the next akka-projection release will have all modules published for Scala 3 (I had missed out on referencing this issue in the PR)

@johanandren johanandren added this to the 1.5.4 milestone Apr 2, 2024
@PerWiklander
Copy link

Is there any plan for when "the next akka-projection release" might happen?

@johanandren
Copy link
Member

In the coming two weeks

@johanandren
Copy link
Member

FYI @PerWiklander this has now been released in akka-projection 1.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants