Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for the PuppetDB crash with newer zip-visit #14

Open
rbrw opened this issue Jul 9, 2024 · 1 comment
Open

Possible fix for the PuppetDB crash with newer zip-visit #14

rbrw opened this issue Jul 9, 2024 · 1 comment

Comments

@rbrw
Copy link

rbrw commented Jul 9, 2024

As previously reported in akhudek/zip-visit#8 PuppetDB crashes when fast-zip is upgraded to 0.7.0. In fact, the trouble actually started with the use of .next in core.cljc in 0.6.0.

That's because PuppetDB has long extended zip (via puppetlabs.puppetdb.zip) to preserve collection types in some cases, e.g. vectors remain vectors. As a result, the .next in core/down encounters a vector instead of a sequence, and crashes. If it would be acceptable, changing the three uses of .next to clojure.core/next would resolve the issue.

In any case, thanks for providing the library.

@akhudek
Copy link
Owner

akhudek commented Jul 9, 2024

Ok I’ll take a look soon. I need to reinstall clojure 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants