Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add makefile and build currentbranch npm scripting #482

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

unlikelyzero
Copy link
Collaborator

Closes #480

Describe your changes:

Adds a Makefile to run make all on a openmct-yamcs PR and have it run the tests against the current branch's openmct branch or master if not found

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@unlikelyzero unlikelyzero added the type:maintenance chore, tests, build, ci label Sep 24, 2024
@unlikelyzero unlikelyzero added this to the Target:4.1.0 milestone Sep 24, 2024
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Collaborator

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions/questions. Also, we use a lot of package scripts in here, should we error handle those incase they are changed in the future unknowingly?

@unlikelyzero
Copy link
Collaborator Author

@jvigliotta added a || exit 1 to the npm scripts

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Collaborator

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unlikelyzero unlikelyzero merged commit c300270 into master Sep 25, 2024
7 of 9 checks passed
@unlikelyzero unlikelyzero deleted the make-and-currentbranch branch September 25, 2024 12:52
Copy link
Collaborator

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance chore, tests, build, ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] Create scripting to quickly switch between version of openmct which matches openmct-yamcs
3 participants