Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss in precision when using historical vs real-time data with YAMCS #406

Open
2 of 5 tasks
unlikelyzero opened this issue Jan 5, 2024 · 1 comment
Open
2 of 5 tasks
Labels
severity:blocker type:bug Something isn't working

Comments

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Jan 5, 2024

Summary

We've been investigating an issue causing certain telemetry to plot incorrectly and noticed that float values coming from YAMCS fetch API and float values coming from websocket connections (using JSON protocol) have differing precision. This first appeared in plots, but is clearer in telemetry tables.

The values from the fetch API (historical) come in as 0.3199999928474426 for example, while realtime values through WebSocket/JSON come in as 0.32.

Interestingly, when using a websocket protobuf implementation, the precision is maintained. Meaning this is likely a problem in the JSON conversion process.

Expected vs Current Behavior

Historical and Websocket queries to return the same dataset.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Environment

  • Open MCT Version: 3.3.0

Additional Information

Websocket JSON Implementation
MicrosoftTeams-image (11)
Websocket protobuf Implementation
MicrosoftTeams-image (12)

@unlikelyzero unlikelyzero added type:bug Something isn't working severity:blocker labels Jan 5, 2024
@unlikelyzero unlikelyzero changed the title [Real-time] Loss in precision when using historical vs real-time data with YAMCS Loss in precision when using historical vs real-time data with YAMCS Jan 5, 2024
@unlikelyzero
Copy link
Collaborator Author

Root Cause yamcs/yamcs#859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:blocker type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant