Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add support for YAMCS token authentication ? #385

Open
bangpradyumna opened this issue Oct 20, 2023 · 2 comments
Open

How to add support for YAMCS token authentication ? #385

bangpradyumna opened this issue Oct 20, 2023 · 2 comments
Labels
type:enhancement New feature or request

Comments

@bangpradyumna
Copy link

Hello,
Thank you so much for developing this plugin! I've set it up and it works for a basic YAMCS instance whose APIs arent protected by token based authentication.

However, I now need to add support for it so that the plugin takes the username and password as part of its config and then gets the bearer token (which is refreshed every 15 mins). This bearer token should be part of every API/Websocket call.

One straightforward approach is to create a tokenManager in utils.js which stores and manages these tokens and then in every fetch() function call, insert the token from this tokenManager. Is there a better way to do this ?

I would really appreciate any help,
Thanks alot!

@unlikelyzero
Copy link
Collaborator

@bangpradyumna we don't have experience with this pattern. I would consider doing all authentication / authorization on your proxy server and then pass that as a role for yamcs to manage

@akhenry akhenry added the type:enhancement New feature or request label Apr 4, 2024
@akhenry
Copy link
Owner

akhenry commented Apr 4, 2024

@bangpradyumna We would love to support token based authentication for Yamcs. None of our current missions use it because we use institutional authentication mechanisms that are outside of Yamcs itself, so we don't have plans to implement this right now.

We would definitely consider a PR that implements this though, I'm sure a lot of folks would find this useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants