Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Disable plugin action for unexpected syntaxes #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kristinita
Copy link

1. Summary

I make, that GitHub Emoji works only for Markdown syntaxes.

2. Behavior before pull request

If:

    I works in non-Markdown syntaxes, →

    GitHub Emoji prevents me

Example for:

    Python syntax:

        I can't indent block:

Before

3. Behavior after pull request

For:

  • Markdown syntax — GitHub Emoji command run,
  • Another syntax — command for syntax run.

After

4. Argumentation

Users don't needs GitHub Emoji for non-Markdown syntaxes, GitHub Emoji prevents them. I want to use Tab for another actions.

5. Testing environment

  • Windows 10 Enterprise LTSB 64-bit EN,
  • Sublime Text Build 3143,
  • GitHub Emoji 1.2.0,
  • Latest versions of Markdown syntaxes from section below.

6. Supported syntaxes

  1. Default:

    1. Markdown,
    2. MultiMarkdown.
  2. MarkdownHighlighting.

  3. MarkdownLight:

    1. MarkdownLight,
    2. MarkdownLight.YAML.
  4. MarkdownEditing:

    1. Markdown (Standard),
    2. MultiMarkdown,
    3. Markdown GFM.
  5. AcademicMarkdown:

    1. AcademicMarkdown,
    2. AcademicYAML.

I doesn't find another non-deprecated Markdown syntax in Package Control.

If these syntaxes exists:

    we need to add them.

Thanks.

@kpym
Copy link

kpym commented Oct 22, 2018

To avoid indentation problems you can check my comment in #10. But I agree that it is even better to limit this plugin to markdown only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants