satisfies does not properly enforce enum on SomeJTDSchemaType
#2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
Closes #2205
What changes did you make?
Made the type of string enums readonly in
SomeJTDSchemaTypeAlso documented the use of
JTDDataTypeto extract types from schema, and the use ofSomeJTDSchemaTypeto ensure a schema is properly formed before sending it toJTDDataTypeIs there anything that requires more attention while reviewing?
This only impacts the typescript typings used in a way that was not documented before ; no impact on the result of the unit tests ; so I don't think so