Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useGoogleOneTabSignIn & useGoogleSignInHandlers Refactor #137

Open
mlajkim opened this issue Dec 26, 2023 · 0 comments
Open

useGoogleOneTabSignIn & useGoogleSignInHandlers Refactor #137

mlajkim opened this issue Dec 26, 2023 · 0 comments
Labels
refactor Refactor codes into the writing convention rules

Comments

@mlajkim
Copy link
Contributor

mlajkim commented Dec 26, 2023

Background

useDevSignIn() hook will be (has been) fixed in the PR #136.

I want to get the useGoogleOneTabSignIn() and useGoogleSignInHandlers() fixed as the useDevSignIn()

TODOs

- [ ] TODO: Write TODOs
- [ ] Fix useGoogleOneTapLogin's `Promise-returning function provided to property where a void return was expected.` warning
- [ ] Fix `Promise-returning function provided to variable where a void return was expected.` warning
- [ ] Try to remove these types if possible
```ts
type PrivateOnSuccess = (credentialResponse: CredentialResponse) => void
type PrivateOnError = () => void
type UseGoogleSignInHandlers = [PrivateOnSuccess, PrivateOnError]
```ts
@mlajkim mlajkim added the refactor Refactor codes into the writing convention rules label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor codes into the writing convention rules
Projects
None yet
Development

No branches or pull requests

1 participant