We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
100m-startup/worker/tasks/fetch-github.js
Line 14 in 9015550
If onPage starts at 0 the results are duplicate between the call with page=0 and page=1. There will be 50 duplicates in your data store.
If you compare the results of these example calls you'll see that is the case: https://jobs.github.com/positions.json?description=ruby&page=0 https://jobs.github.com/positions.json?description=ruby&page=1
Probably not critical for this tutorial sample app, but pointing it out for good measure. 🙂
It's a small change to make, but if you'd like a PR let me know.
The text was updated successfully, but these errors were encountered:
yes, I simply changed onPage=0 to onPage=1. It removed duplicate elements from allJobs
onPage=0
onPage=1
allJobs
Sorry, something went wrong.
No branches or pull requests
100m-startup/worker/tasks/fetch-github.js
Line 14 in 9015550
If onPage starts at 0 the results are duplicate between the call with page=0 and page=1. There will be 50 duplicates in your data store.
If you compare the results of these example calls you'll see that is the case:
https://jobs.github.com/positions.json?description=ruby&page=0
https://jobs.github.com/positions.json?description=ruby&page=1
Probably not critical for this tutorial sample app, but pointing it out for good measure. 🙂
It's a small change to make, but if you'd like a PR let me know.
The text was updated successfully, but these errors were encountered: