Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avcc->pps_table is initialised using the SPS count instead of the PPS count #57

Open
yannlandry opened this issue Jun 19, 2024 · 1 comment

Comments

@yannlandry
Copy link
Contributor

At line 51 in read_avcc(), avcc->pps_table is initialised using avcc->numOfSequenceParameterSets where it should probably be using avcc->numOfPictureParameterSets. Otherwise, there could be an out-of-bound situation if the number of PPS is greater than the number of SPS.

avcc->pps_table = (pps_t**)calloc(avcc->numOfSequenceParameterSets, sizeof(pps_t*));

@aizvorski
Copy link
Owner

Well spotted! Mind submitting a PR with a patch? Would be an instant-merge ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants